search

acrisci / simple-breakpad-server

Simple breakpad crash reports collecting server
https://www.npmjs.com/package/simple-breakpad-server
MIT License
67 stars 29 forks source link

Fix out of memory errors by adding "filesInDatabase" option #13

Closed Jimbly closed 6 years ago

Jimbly commented 6 years ago

I ran into some out of memory errors on my (albeit small) instance when the uploaded dumps got to a couple GB, and more recently when the uploaded symbols got to a couple GB, so I added an option to store all uploaded files on disk instead of in the database. This reduced my runtime memory usage of the breakpad server from a few GB down to a few MB, solving my issues.

acrisci commented 6 years ago

Yeah looks ok :+1: .

Jimbly commented 6 years ago

I've been using simple-breakpad-server in production for about a year, needed the first part of this change quite a while ago, just added the same thing for symbol files today, and figured I should finally clean things up and send a PR. Somehow the commit history is showing a bunch of commits that were already merged, I'm not sure if that matters, but I could clean that up before merging here (or, probably better, just squash down to one commit) if it'd make the history better =).

acrisci commented 6 years ago

Awesome, glad I could make something that was useful to someone.

A cleanup would be good.

The project I wrote this for got cancelled so I'm not using it anymore. If you want to take over development of new features go ahead and just tell me when you want it to be released.

Jimbly commented 6 years ago

Okay, squished down to one commit, should merge good now =). I'm happy to be a maintainer, though I don't plan on doing much more development. At least, not until something crashes again or I suddenly need a new feature. I'll gladly look at PRs and join in any conversations though.

acrisci commented 6 years ago

Thanks :+1: .