acro5piano / react-native-big-calendar

gcal/outlook like calendar component for React Native
https://react-native-big-calendar.vercel.app
MIT License
451 stars 152 forks source link

Add locale property to CalendarHeaderProps interface #1109

Closed winie closed 1 month ago

winie commented 1 month ago

First of all, I would like to thank you for providing this component. We use it in our open source project, which is an app for our students.

I have added the locale property to the CalendarHeaderProps interface. In the _CalendarContainer component (currently on line 377) the locale value is stored in the headerProps constant. The headerProps constant is later transferred to the HeaderComponent component as properties. If a custom header renderer is programmed, the calendar transfers the desired language. In my humble opinion, this is good software design.

Unfortunately, you first have to read the code to recognize this fact, because the locale property is missing in the CalendarHeaderProps interface. Otherwise you could already recognize the transfer of the language in the CalendarHeaderProps interface.

vercel[bot] commented 1 month ago

Someone is attempting to deploy a commit to the Kazuya Gosho's projects Team on Vercel.

A member of the Team first needs to authorize it.

acro5piano commented 1 month ago

@winie Good catch! Thank you for your contribution.

acro5piano commented 1 month ago

Released on v4.15.1

winie commented 1 month ago

Thanks