search

actions-on-google / actions-on-google-testing-nodejs

Apache License 2.0
75 stars 18 forks source link

Added ability to handle SIGN_IN and NEW_SURFACE intents #35

Closed adamcohenrose closed 5 years ago

adamcohenrose commented 5 years ago

We use the SIGN_IN and NEW_SURFACE intents in our action, so this change enables us to test that we're returning them at the right times.

I've also updated the dependencies to the latest versions to fix the audit warnings that were coming up all the time.

googlebot commented 5 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot commented 5 years ago

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

Fleker commented 5 years ago

Hey there! You'll need to make sure you sign the CLA. Additionally, it looks like you may need to rebase your change on master.

adamcohenrose commented 5 years ago

Yes, sorry -- I committed with the wrong email address, then screwed up history when I tried to change the commits! I'll fix it today -- should be an easy merge.