actions / actions-runner-controller

Kubernetes controller for GitHub Actions self-hosted runners
Apache License 2.0
4.76k stars 1.12k forks source link

Helm warning when using gha-runner-scale-set as app dependency #3620

Open rfinnie-epic opened 5 months ago

rfinnie-epic commented 5 months ago

Checks

Controller Version

0.9.2

Deployment Method

Helm

Checks

To Reproduce

Chart.yaml:

---
apiVersion: 'v2'
name: 'arc-runners'
description: 'GitHub arc runners'
type: 'application'
version: '0.1.0'

dependencies:
  - name: 'gha-runner-scale-set'
    version: '0.9.2'
    repository: 'oci://ghcr.io/actions/actions-runner-controller-charts'

values.yaml:

---
gha-runner-scale-set:
  githubConfigUrl: 'https://github.com/enterprises/example'
  githubConfigSecret: 'runner-pat'
  # ...

Run:

helm install my-label --namespace arc-runners --values ./values.yaml .

Describe the bug

When the above chart is installed or upgraded while pulling in gha-runner-scale-set as a dependency, it produces the following Helm warning:

Release "my-label" does not exist. Installing it now.
coalesce.go:286: warning: cannot overwrite table with non table for arc-runners.gha-runner-scale-set.githubConfigSecret (map[github_token:])
NAME: my-label
LAST DEPLOYED: Sun Jun 23 15:30:22 2024
NAMESPACE: arc-runners
STATUS: deployed
REVISION: 1
TEST SUITE: None

This warning appears to be harmless as it does successfully use the runner-pat k8s secret, but I'm not sure if it's a error on the upstream chart, or with Helm itself.

Describe the expected behavior

No warning

Additional Context

See above

Controller Logs

N/A

Runner Pod Logs

N/A
github-actions[bot] commented 5 months ago

Hello! Thank you for filing an issue.

The maintainers will triage your issue shortly.

In the meantime, please take a look at the troubleshooting guide for bug reports.

If this is a feature request, please review our contribution guidelines.