search

actix / actix-extras

A collection of additional crates supporting the actix and actix-web frameworks.
https://actix.rs
Apache License 2.0
762 stars 192 forks source link

Settings: actix.mode has no actix behaviour associated #387

Open jayvdb opened 8 months ago

jayvdb commented 8 months ago

Your issue may already be reported! Please search on the actix-extras issue tracker before creating one.

Expected Behavior

I expect that all of the settings under the "actix" table correspond to some actix behaviour.

Current Behavior

The config field "actix.mode" has no actix behaviour associated with it, and is ignored by ApplySettings.

Possible Solution

IMO having a mode config is very helpful, being a very common concept, so I suggest it is moved into the application part of the config structure, or another config section being created such as "common" for config that actix-settings provides but doesnt have any implemented behaviour.

Another alternative is for actix-settings to use this mode value to provide different defaults for prod vs dev, and document this.

Steps to Reproduce (for bugs)

Context

Your Environment