actix / actix-extras

A collection of additional crates supporting the actix and actix-web frameworks.
https://actix.rs
Apache License 2.0
760 stars 191 forks source link

Add better support for receiving larger payloads #430

Closed asonix closed 1 month ago

asonix commented 4 months ago

PR Type

Feature

PR Checklist

Overview

This change enables the maximum frame size to be configured when receiving websocket frames. It also adds a new stream time that aggregates continuation frames together into their proper collected representation. It provides no mechanism yet for sending continuations.

bjones1 commented 2 months ago

I'm using the Actix Web framework in the CodeChat Editor, a text editor/word processor which renders markdown-formatted comments in source code. This is similar toJupyter, but applies to an entire programs, not just snippets of code. I use the actix-ws module to move source code between the web-based editor and the server (which is implemented in Rust). Unfortunately, the current release of the actix-ws module cannot transport source code > 64 KB over a websocket. This PR solves this problem, which is very exciting!

Is there anything I can do to support getting this PR merged? Thanks for the great work on this project!

robjtede commented 2 months ago

I'll put some focus on webdockets this week. PR should be good to go as is. I appreciate the patience.

bjones1 commented 2 months ago

@robjtede, fantastic, thank you!

Slixe commented 1 month ago

Hey there, I'm relying heavily on actix and I'm the one who originally requested this feature in the Discord server, thanks for your PR! Hope to see it soon as I'm getting some bugs :)

robjtede commented 1 month ago

Thanks for the work on this @asonix!

~Think we'll get this released today 🚀~

Done: https://github.com/actix/actix-extras/releases/tag/ws-v0.3.0

bjones1 commented 1 month ago

@robjtede, fantastic, thanks! I appreciate it!!!