AJPfleger commented 1 week ago

We concluded, that there is not really a use for ActsScalar as it is now:

CPUs should have the same performance for float and double
If we wanted to check performance, we would want separate scalar types for all components
It is too complicated to adapt everything correctly.

blocked by:

https://github.com/acts-project/acts/pull/3894

coderabbitai[bot] commented 1 week ago

[!IMPORTANT]

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

216 files out of 298 files are above the max files limit of 75. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

github-actions[bot] commented 1 week ago

📊: Physics performance monitoring for e2abc00b690705d3176b4e057f7e093bceebda07

Full contents

physmon summary

andiwand commented 1 week ago

this needs patches in Athena

acts-project-service commented 1 week ago

:white_check_mark: Athena integration test results [622902b734a8cc9c68d1a819c90eabd20295c03e]

:white_check_mark: All tests successful

status	job	report
:green_circle:	report_pull_request
:green_circle:	run_art_test: test_run4_acts_vertex_PU200
:green_circle:	run_art_test: test_run4_ttbar_PU200
:green_circle:	run_art_test: test_data18_13TeV_1000evt
:green_circle:	run_art_test: test_ttbarPU40_reco
:green_circle:	run_workflow_tests_run4_mc
:green_circle:	run_workflow_tests_run2_mc
:green_circle:	run_workflow_tests_run2_data
:green_circle:	run_workflow_tests_run3_mc
:green_circle:	run_workflow_tests_run3_data
:green_circle:	test_ActsDumpGeometryIdentifiers
:green_circle:	test_ActsCheckObjectCountsWorkflowHgtd
:green_circle:	test_ActsCheckObjectCountsCachedWorkflow
:green_circle:	test_ActsCheckObjectCountsWorkflow
:green_circle:	test_ActsEFTrackFit
:green_circle:	test_ActsPersistifySeeds
:green_circle:	test_ActsBenchmarkWithSpot
:green_circle:	test_ActsAnalogueClustering
:green_circle:	test_ActsWorkflowHeavyIons
:green_circle:	test_ActsWorkflowFastTracking
:green_circle:	test_ActsWorkflowCached
:green_circle:	test_ActsWorkflow
:green_circle:	test_ActsValidateAmbiguityResolution
:green_circle:	test_ActsValidateResolvedTracks
:green_circle:	test_ActsValidateTracks
:green_circle:	test_ActsValidateActsCoreSpacePoints
:green_circle:	test_ActsValidateActsSpacePoints
:green_circle:	test_ActsValidateSeeds
:green_circle:	test_ActsValidateOrthogonalSeeds
:green_circle:	test_ActsValidateClusters
:green_circle:	test_ActsPersistifyEDM
:green_circle:	test_ActsGSFRefitting
:green_circle:	test_ActsKfRefitting
:green_circle:	test_ActsExtrapolationAlgTest
:green_circle:	test_ActsITkTest
:green_circle:	run_unit_tests