actum / gulp-dev-stack

Actum dev stack based on gulp
MIT License
11 stars 7 forks source link

Pre-commit hook #52

Closed janpanschab closed 8 years ago

janpanschab commented 8 years ago

Add build task to pre-commit hook. http://elijahmanor.com/npm-precommit-scripts/

vbulant commented 8 years ago

I find this quite disturbing. Especially during gulp-stack development. What about having it as a pre-push hook/script?

Rationale:

The push hook would still catch any errors before pushing them to the repo without sacrificing the productivity.

janpanschab commented 8 years ago

build on every commit is pretty time consuming

I like it as pre-commit hook, because it prevent broken commits.

I often edit stuff which doesn’t deal with build related files

If you are sure you doesn’t deal with build related files you can force a commit with --no-verify

vbulant commented 8 years ago

I can see your point. Still I’d like to discuss it on the next 1:1 meeting. Closing the issue :)

kettanaito commented 8 years ago

How about running only linting tasks on this hook?

janpanschab commented 8 years ago

Change to pre-push hook.