ad-si / brickify

Speed up 3D printing using LEGO® bricks
9 stars 1 forks source link

refactor layouter and layout optimization #651

Closed johannesdeselaers closed 9 years ago

johannesdeselaers commented 9 years ago

replaces #629 now includes

stuikomma commented 9 years ago

For consistency use the term brick instead of 3L. Once in Layouter and in LegoPipeline.

stuikomma commented 9 years ago

sometimes I get this error when relayouting:

TypeError: this.plateLayouter.layout(...).then is not a function
    at LayoutOptimizer.splitBricksAndRelayoutLocally (http://localhost:3000/app.js:41778:55)
    at LayoutOptimizer.splitBricksAndRelayoutLocally (http://localhost:3000/app.js:41624:57)
    at Object.LegoPipeline.pipelineSteps.push.worker (http://localhost:3000/app.js:42259:40)
    at LegoPipeline.module.exports.LegoPipeline.runStep (http://localhost:3000/app.js:42322:19)
    at LegoPipeline.module.exports.LegoPipeline.runPromise (http://localhost:3000/app.js:42302:19)
    at LegoPipeline.runPromise (http://localhost:3000/app.js:42145:57)
    at http://localhost:3000/app.js:42309:24
    at lib$es6$promise$$internal$$tryCatch (http://localhost:3000/shared.js:6228:16)
    at lib$es6$promise$$internal$$invokeCallback (http://localhost:3000/shared.js:6240:17)
    at http://localhost:3000/shared.js:6785:13
johannesdeselaers commented 9 years ago

the error was caused by a missing Promise.resolve in the layout method of Layouter

stuikomma commented 9 years ago

And, of course, the numerous comments that don't start with a capital letter :wink: # [a-z] may help.

stuikomma commented 9 years ago

Some comments remain

stuikomma commented 9 years ago

:postbox: