Feature/optimize layout using articulation points

ad-si / brickify

Speed up 3D printing using LEGO® bricks

9 stars 1 forks source link

Feature/optimize layout using articulation points #719

Open johannesdeselaers opened 9 years ago

johannesdeselaers commented 9 years ago

should be merged after #691

checks of second checkmark of #431 , thus closes #431

please tell me if you think the relayout runtime is acceptable, or whether this still needs optimization

I did not take the (debug) coloring of the articulation points out for the moment, so you can see what's going on (blue = insignificant articulation point, green = significant articulation point that should be fixed). This should be done before merging this pull request.

AtiX commented 9 years ago

Relayouting speed (after releasing the brush) is fine for me. But:

Overall interaction is slower and more laggy, the brush is not as responsive as on brickify.it. how can this be?
It seems like this algorithm produces much more plates and less lego bricks?

johannesdeselaers commented 9 years ago

hmm, about the laggy interaction: no idea I don't remember touching any brush/interaction/rendering code (except for the brick colors) I will check.

As for the increased number of plates: that is expected. Plates are far more stable & connected, so when the algorithm tries to remedy unconnected components or weak articulation points, it currently only uses plates to relayout. I tried using both bricks and plates, but that did not work out well.

AtiX commented 9 years ago

Any updates on the slower interaction?