search

adabru / BleWinrtDll

BLE for Unity 3d in Windows without UWP.
Do What The F*ck You Want To Public License
168 stars 52 forks source link

Issue 20: Connect Characteristics dropdown to SelectCharacteristic() #25

Closed ehauner closed 2 years ago

ehauner commented 2 years ago

This is a fix for #20

I don't have much experience with Unity projects and git. Please let me know if I should remove any of these files from the commit. Part of the change includes changing the Unity version, and I think that required the addition of some files.

adabru commented 2 years ago

Thanks @ehauner for the pull request! I guess the relevant lines are 3542-3554 in Demo.unity . Could you try to exclude the version change from the commit? E.g. by committing once after import, once after doing the change and then cherrypicking the change onto master? I'm not feeling very good when changing the version.

Btw instead of reopening the pull request you can also force push :+1:

ehauner commented 2 years ago

Yes. To be safe, I'll get a matching version of Unity then make the change. I didn't feel great about changing the version either.

ehauner commented 2 years ago

Updated and tested

adabru commented 2 years ago

Great!