search

adafruit / Adafruit_ADS1X15

Driver for TI's ADS1015: 12-bit Differential or Single-Ended ADC with PGA and Comparator
Other
289 stars 301 forks source link

Add ability to configure Data Rate #56

Closed caternuson closed 3 years ago

caternuson commented 3 years ago

Re this thread: https://forums.adafruit.com/viewtopic.php?f=19&t=175501

Add ability to configure Data Rate? i.e, the DRx bits in the Config Register. Looks like things are currently hard wired to a single value.

caternuson commented 3 years ago

Added with #59

Russell108 commented 1 year ago

Calling this function data rate is not intuitive Why not call it sample rate well I am assuming this is what is being configured

caternuson commented 1 year ago

It reflects the nomenclature from the datasheet:

image

Russell108 commented 1 year ago

I Believe I have realised this library has a limitation

evet though the data rate is changed, it does little to speed up the delivery of data to the Arduino

Since it uses a time rather than the alarm to check if data is available to read

In my opinion, this makes the library very ineffective in real terms.

This library does a better job. https://github.com/jrowberg/i2cdevlib

On 10 Dec 2022, at 16:27, Carter Nelson @.***> wrote:

It reflects the nomenclature from the datasheet:

https://user-images.githubusercontent.com/8755041/206864901-87cf1d1b-a450-43a8-b877-88f8eecbc23c.png — Reply to this email directly, view it on GitHub https://github.com/adafruit/Adafruit_ADS1X15/issues/56#issuecomment-1345299883, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEYL32L2IDQDA4JL4ZHC4LWMSVOZANCNFSM4XW5MDGA. You are receiving this because you commented.