search

adafruit / Adafruit_CircuitPython_FeatherWing

CircuitPython classes for Adafruit FeatherWings
MIT License
11 stars 13 forks source link

Linted #75

Closed evaherrada closed 3 years ago

evaherrada commented 3 years ago

had to disable unspecified-encoding in a few spots. Looked into it a bit, and to be honest I feel like we should get rid of the check org-wide. I've come across it in a few places and every time I came across it I ended up disabling it.

kattni commented 3 years ago

I'm also wondering why it's not failing on other libraries that have open() without encoding specified.

evaherrada commented 3 years ago

@kattni I think they are now. Pretty sure it's just because we changed the pylint version. It's a pretty recent one

kattni commented 3 years ago

I was referring to a few that I merged earlier that were not disabled, but the PR passed. Either way, we're disabling globally at this point. So it's fine.

evaherrada commented 3 years ago

Sure

kattni commented 3 years ago

@dherrada I'm going to give the contributor on #74 an opportunity to integrate these changes into their PR before merging this one over theirs. Please still remove the disable I mentioned in my last comment, so they have the appropriate set of changes to work with. If they're not interested in integrating into their PR, I'll merge this at that point.

evaherrada commented 3 years ago

Ah ok

kattni commented 3 years ago

Closing in favor of #74