HTTPS implementation - Githubissues

michalpokusa commented 9 months ago

Depends on #84, #87 and https://github.com/adafruit/circuitpython/issues/9003

⭐ Added:

HTTPS functionality that works on ESP32-S3 and CPython, due to #87 other platforms might not work
Example of using adafruit_httpserver with HTTPS

🛠️ Updated/Changed:

Server constructor now accepts https, certfile and keyfile args that together enable HTTPS
In debug mode, time it took server to handle the request is now measured from before .accept(), which includes the time of handling TLS decryption, thus the time is more "correct"
Docs now include info about HTTPS

🏗️ Refactor:

Some parts of docs that used to have bolded paragraphs not have them in Sphinx's notes

After fixing the issues mentioned at the top, this code should also work on other platforms than ESP32-S3.

dhalbert commented 5 months ago

@michalpokusa I'm sorry we missed merging this. Is it ready to go? Any retesting needed since various other library changes? Thanks.

michalpokusa commented 5 months ago

@michalpokusa I'm sorry we missed merging this. Is it ready to go? Any retesting needed since various other library changes? Thanks.

No problem. I didn't push on merging this as although this works (or did when I marked it as ready) on ESP32-S3, it is not compatible with RPico, S2 etc. Recently there were also some changes to the SSL module on CircuitPython, so I was waiting on how things play out.

I am not sure whether the MemoryError is fixed on other MCUs or if there are plans to resolve them in future.

Meanwhile this PR can be merged as is or I could add a warning that prints info about compatibility or checks the board id, or I can convert it to draft for now. Please tell me what would be best in your opinion.

Retest is always good, if you decide to merge I will do it with latest CircuitPython.

adafruit / Adafruit_CircuitPython_HTTPServer

HTTPS implementation #88