pypi version is broken

[walchko]

Hello! When I updated to current version, I am unable to import adafruit_lsm6ds. However, if I uninstall it and load a previous version with pip install adafruit-circuitpython-lsm6ds==3.0.2, I can now import it. Am I missing something with version 4?

This fails for me on the current macOS and Ubuntu 20.04 using python 3.8.

[FoamyGuy]

@walchko the module was split apart into separate files I believe the import now needs to specify the type of hardware sensor that you are using. e.g.

from adafruit_lsm6ds.lsm6ds33 import LSM6DS33

See the updated scripts in the examples folder for the specific syntax of the other types of devices the library supports.

[walchko]

No, that doesn't work. You cannot import adafruit_lsm6ds ... it doesn't exist. I should still be able to do import adafruit_lsm6ds and get everything, but when I do it can't find it.

[FoamyGuy]

Try version 4.0.1

pip3 install adafruit-circuitpython-lsm6ds==4.0.1

That is the most recent version before the library was split into a directory I think. after installing that one I am able to import it successfully.

[FoamyGuy]

I think the setup.py file needs to be updated to use packages here:

https://github.com/adafruit/Adafruit_CircuitPython_LSM6DS/blob/305c6583dd99b7584636e6d65248aaebcc71d89b/setup.py#L61

and it should fix this issue. @walchko do you want to make a PR to fix this for us? No problem if not we should be able to get it resolved soon.

[walchko]

sure ... tomorrow :smile:

[walchko]

done ... there are other small issues though:

• package metadata is wrong, this works on python 3.7 and 3.8, I haven't tested 3.6. Also, isn't this more Beta level or higher?

  classifiers=[
      "Development Status :: 3 - Alpha",
      "Intended Audience :: Developers",
      "Topic :: Software Development :: Libraries",
      "Topic :: System :: Hardware",
      "License :: OSI Approved :: MIT License",
      "Programming Language :: Python :: 3",
      "Programming Language :: Python :: 3.4",
      "Programming Language :: Python :: 3.5",
  ],

• you only make source packages on pypi, not wheels ... why?

  • I can see you are trying to build wheels here, but it isn't getting pushed to pypi

  - name: Build Python package
    run: |
      pip install --upgrade setuptools wheel twine readme_renderer testresources
      python setup.py sdist
      python setup.py bdist_wheel --universal
      twine check dist/*

  • I am unfamiliar with the --universal ... never used that before
  • Also, I have switched to poetry and just use a pyproject.toml which holds everything now ... it is awesome
    • Oh, I have no affiliation with poetry other than I really like it
• There is the temperature sensor access, but I have that under a different issue ticket as an enhancement

[FoamyGuy]

Closing this for now. #28 has follow up questions about setup.py from above.