search

adafruit / Adafruit_nRF52_Bootloader

USB-enabled bootloaders for the nRF52 BLE SoC chips
MIT License
438 stars 393 forks source link

remove dfu timeout #166

Closed hathach closed 3 years ago

hathach commented 3 years ago

fix #164

hathach commented 3 years ago

hmm @dhalbert ci failed to build, complaining the flash is overflow, I am building just fine locally with the very same version of gcc. I just trigger a rebuild of good-old master, and it failed as well. Very weird issue :thinking: :thinking:

Update: I am able to reproduce it locally, the official version is the same 9.3.1 but the latest is 9.3.1-1.2.1 while mine is 9.3.1-1.1.1. Sigh, turn out this is not as quick as I think :sweat_smile:

UPDATE2: seem like 9.3.1-1.2.1 is xpakced modified version https://github.com/xpack-dev-tools/arm-none-eabi-gcc-xpack/releases/ . The 9.3.1-1.1.1 is the actual 9-2020-q2 from ARM. Somehow their modified version significantly increased the compile size of bootloader (around 6-7KB more). Since the next release of armgcc is gcc10, I will wait for arm official toolchain and stick to the 1.1.1 for now.

dhalbert commented 3 years ago

I merged the PR (maybe I should have waited for you), and the build failed: https://github.com/adafruit/Adafruit_nRF52_Bootloader/runs/1075498601

hathach commented 3 years ago

I merged the PR (maybe I should have waited for you), and the build failed: https://github.com/adafruit/Adafruit_nRF52_Bootloader/runs/1075498601

restart the build should fix this, I think it is caused by parallel compiling with make -j 4. I experience something similar when compile parallel with clean all in local machine. I am not entirely sure though, it was OK until recently. Don't worry I will look at it later on.