search

adafruit / Adafruit_nRF52_Bootloader

USB-enabled bootloaders for the nRF52 BLE SoC chips
MIT License
438 stars 393 forks source link

adding support for generic nrf52833 board #198

Closed braingram closed 2 years ago

braingram commented 3 years ago

I had a need to get this working on a custom nrf52833 board and wanted to share the result. I don't have a pca10100 to test with but could get one if it would prove useful in validating this pull request. Otherwise I added a 'generic nrf52833'.

I wasn't sure what to put for usb vendor and product ids so please do let me know if those should be changed.

braingram commented 3 years ago

Thanks for the feedback. The denial of the generic board totally makes sense to me. I have a pca10100 on order to test out the bootloader on that device. Once it's in I'll change this pull request to focus only on changes to the existing pca10100. It's likely the only remaining change will be to the src/usb/uf2/uf2cfg.h file.

jpconstantineau commented 2 years ago

@braingram Some of the changes were merged in with #251 I suggest reviewing your changes (see comments in my PR) and decide whether to close or update this PR