adafruit / nina-fw

Firmware for u-blox NINA W102 WiFi/BT module
85 stars 43 forks source link

Abstracted pinning from individual source files #20

Open mubes opened 4 years ago

mubes commented 4 years ago

Moved pinning rules and definitions from individual source code files into a separate pinning.h file. Created alternate pinning which should be compatible with QSPI working, and running via the IOMUX for single bit SPI.

There should be no change in functionality unless the OPTIMISED_PINNING define is set in the makefile, but this needs testing on an existing target board (which, I'm afraid, I don't have) before this patch should be merged.

mubes commented 4 years ago

Brent,

Hi, thanks for taking a look at this.

It’s not worth folding this in at the moment as it doesn’t really offer any new functionality yet. I will make further changes and push them onto this same branch...I’ve just sent some boards off for build so should have something to work with shortly. if I’ve not mucked things up too badly then we should have QSPI operational on that.

Dave

On 31 Mar 2020, at 19:51, Brent Rubell notifications@github.com wrote:

 @brentru requested changes on this pull request.

@mubes This looks good, tested on a PyPortal Titano. You'll need to update the PR a bit for the new version number:

Please update the Changelog: https://github.com/adafruit/nina-fw/blob/master/CHANGELOG

Please update this line in the makefile to 1.7.0: https://github.com/adafruit/nina-fw/blob/master/Makefile#L31

Update version here: https://github.com/adafruit/nina-fw/blob/master/combine.py#L34

and here: https://github.com/adafruit/nina-fw/blob/master/main/CommandHandler.cpp#L31

Ping me when you're ready for me to take another look.

1.6.0 Firmware OK MAC: A4:CF:12::96:B8 Scanning available networks... Scan Networks number of available networks:10 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

brentru commented 4 years ago

@mubes np - tag me when you're ready for another look/review.