search

adam-may / hudson-tray-tracker

Automatically exported from code.google.com/p/hudson-tray-tracker
0 stars 0 forks source link

Success sound plays on every refresh #76

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
the sound should only play if a new build was successful not every time it 
checks the server for an update.

Original issue reported on code.google.com by james.cl...@gmail.com on 29 Apr 2011 at 4:49

GoogleCodeExporter commented 9 years ago 
I'm seeing (hearing) the same thing.  When the build is broken, the "broken" 
sound plays every time it updates.

Original comment by clough42 on 11 May 2011 at 3:46

GoogleCodeExporter commented 9 years ago 
I spent some time working on this today, and the issue seems to be related to 
the logic that determines when a build state has changed.  Currently, it just 
checks to see if the build was running during the previous poll.  This means 
when a build is running, the sound will play on every poll, beginning with the 
second poll.

The attached patch changes the logic to look at the last completed build number 
and it only considers playing a sound when the last completed build number 
changes.

This works for me.  It might work for you.

Original comment by clough42 on 11 May 2011 at 9:33

Attachments:

GoogleCodeExporter commented 9 years ago 
Because of this issue, we can't use the sound notification.

When the build was broken and is rebuilding, the sound would cry during the 
entire build.  For a build taking a few minutes, that just horrible.

It would be very nice to have a new release with this patch.

Original comment by gscok...@gmail.com on 19 Dec 2013 at 9:33