search

adam7 / delugia-code

Can we add Nerd Fonts to Cascadia Code Font using a GitHub Action
MIT License
567 stars 34 forks source link

Update Delugia Code with newest version? #52

Closed DennisGaida closed 3 years ago

DennisGaida commented 3 years ago

I love using Delugia Code since it is currently the only "working" version of Cascadia Code with all Nerd Fonts patched.

The Nerd-Fonts font has rendering issues (with my setup). The official PL-version of Cascadia Code does not include all Nerd Fonts, but only the Powerline Symbols.

So any chance of updating Delugia Code with the newest font version. Currently that is 2102.03: https://github.com/microsoft/cascadia-code/releases/tag/v2102.03 and it was just released yesterday - maybe this can also automated with a Github action?

Finii commented 3 years ago

Please have a look at https://github.com/adam7/delugia-code/releases

Finii commented 3 years ago

maybe this can also automated with a Github action?

It actually is possible, and we discussed it some aeons ego. And for some reason I can't remember we decided against it. I think even the needed changes were in that discussion.

If that is your issue, please reopen.

Finii commented 3 years ago

Oh, this I missed.

Seems since commit 73324cc73cf5d160fa9625a2c7a9ed54c93bcf86 we already have automated re-releases. It checks once every 24h.

DennisGaida commented 3 years ago

Seems since commit 73324cc we already have automated re-releases. It checks once every 24h.

Whoops, then sorry for the issue! A bit premature. I was just so excited - Delugia Code is still better than the Nerd Fonts version or the offical MS version.

Finii commented 3 years ago

Do you have any details what is different from Nerd Fonts' version? We started before they did, so I did not really follow that too closely. And had one bug in font-patcher fixed upstream after fixing it for Delugia.