search

adam900710 / btrfs-fuse

A read-only, license friendly, FUSE based btrfs implementation
Other
27 stars 4 forks source link

Mark test dependencies as not required #6

Closed davide125 closed 2 years ago

davide125 commented 2 years ago

Test dependencies aren't required for btrfs-fuse to actually compile and work, so mark them as such. Among other things, this allows one to build btrfs-fuse of a CentOS / RHEL system that doesn't ship btrfs-progs.

Conan-Kudo commented 2 years ago

@davide125 Wouldn't it make sense to add a meson option for testing and test dependencies, and flag this based on that?

davide125 commented 2 years ago

Yeah, we could do that too. @adam900710 what do you prefer?

Conan-Kudo commented 2 years ago

I think it would be better to do it that way because it's more explicit and makes it easier to identify things (read: bcond in a spec file and such).

adam900710 commented 2 years ago

Sorry, I'm not an expert in meson (that's why I'm trying to use meson, as a practice).

But if there is a way to explicitly define dependencies for selftest, I'd prefer that.

And for the libbtrfsutil dependency, it's mostly for fsstress subvolume/snapshot create/delete. If someone is really interested in that, it may be a good idea to call the ioctl directly without using the wrapper.

Conan-Kudo commented 2 years ago

@davide125 ping?

davide125 commented 2 years ago

Updated to use a meson knob to gate these (and fixed a bug while at it).