search

adamcharnock / django-hordak

Double entry accounting in Django
http://django-hordak.readthedocs.io
MIT License
231 stars 55 forks source link

Relax Account.name max_length restriction #47

Closed jordanmkoncz closed 1 month ago

jordanmkoncz commented 4 years ago

Currently, the Account.name field is defined as name = models.CharField(max_length=50). Assuming there is no particular reason why the max_length is restricted to 50 characters, could we increase this to max_length=255?

In my case, I'm wanting to create some Accounts with names that include a UUID value (generated using uuid.uuid4) which is 36 characters long by itself, making it hard to add other relevant content to the name field.

adamcharnock commented 4 years ago

Hi Jordan,

Thanks for raising this. Yep, this can and should definitely happen. Do you mind opening a PR with the model change and associated migration?

On Tue, 18 Feb 2020 at 21:36, Jordan Koncz notifications@github.com wrote:

Currently, the Account.name field is defined as name = models.CharField(max_length=50). Assuming there is no particular reason why the max_length is restricted to 50 characters, could we increase this to max_length=255?

In my case, I'm wanting to create some Accounts with names that include a UUID value (generated using uuid.uuid4) which is 36 characters long by itself, making it hard to add other relevant content to the name field.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/adamcharnock/django-hordak/issues/47?email_source=notifications&email_token=AABBXZ2FSUUEHXK3UE2FCQTRDRID3A5CNFSM4KXM4JJKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IOOL7MA, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABBXZ4NXZZ2SM32XEGMPXLRDRID3ANCNFSM4KXM4JJA .

adamcharnock commented 1 month ago

Four years later, and done!