search

adamgreig / labrador-ldpc

LDPC encoding and decoding for Labrador
MIT License
35 stars 4 forks source link

Encoding parity out-of-band #4

Closed scd31 closed 1 year ago

scd31 commented 1 year ago

I am trying to implement the following structure:

image

Since the parity bits are stored separately from the data, it's a bit wasteful to create a data/parity array just to immediately separate the values again. So I wrote some methods that allow encoding the parity bits without needing to append them to the existing data array.

I also made some methods const (and accidentally ran rustfmt on the file) but I can take out these changes if you prefer.

Thanks!

adamgreig commented 1 year ago

Thanks for the PR! The concept sounds fine, but it's really hard to review the changes when the reformatting is mixed in. Please could you undo the formatting changes?

No problem with making more methods const where possible, const fns were pretty much not a thing when most of this was written.

scd31 commented 1 year ago

Sounds good! Yeah, rustfmt really did a number on the formatting :sweat_smile: