adamhaile / surplus

High performance JSX web views for S.js applications
636 stars 26 forks source link

Fix jsx examples #55

Closed brodybits closed 6 years ago

brodybits commented 6 years ago

Fixes for JSX examples

Additional documentation fix included

Child elements example fixes

I found the following sample line to be confusing:

var span = <span>a dynamic child</span>,
    // ...

(the span var itself does not seem to be a dynamic child element)

proposed change in this PR to read as follows:

var span = <span>child of a dynamic div</span>,
    // ...

Other child element fixes proposed in this PR:

brodybits commented 6 years ago

I just force-pushed the following updates:

P.S. I also added a couple more changes to add spacing after jsx examples and fix pointer to CodePen demo.

adamhaile commented 6 years ago

Thanks again, Chris, for taking a close look at the README. I'm still thinking about some of your other suggested changes. I may do a pass with some revisions, and would love your opinions after that.

brodybits commented 6 years ago

Thanks for merging