adamvoss / vscode-yaml

YAML language support, including JSON Schema validation, for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=adamvoss.yaml
MIT License
29 stars 5 forks source link

The server crashes #10

Open leedstark opened 7 years ago

leedstark commented 7 years ago

VSCode said the server crashed 5 times in 3 minutes. It won't be started again.

adamvoss commented 7 years ago

Thank you for reporting this. To fix this it will help to know more about the issue. When this happens, there should be a stack trace and exception information under Output (CTRL+K CTRL+H). Could you provide the information from there? Also if you know how to cause this issue, that would help me to find the issue and test a fix.

lee-baker commented 7 years ago

I get this issue also, it happens as soon as I open a YAML file.

The output is

[Info - 1:51:07 pm] Connection to server got closed. Server will restart. enable Unsupported feature, node kind: 5 C:\Users\Lee.vscode\extensions\adamvoss.yaml-0.0.8\server\node_modules\vscode-yaml-languageservice\lib\parser\yamlParser.js:138 valueNode.location = key.value; ^

TypeError: Cannot set property 'location' of undefined at recursivelyBuildAst (C:\Users\Lee.vscode\extensions\adamvoss.yaml-0.0.8\server\node_modules\vscode-yaml-languageservice\lib\parser\yamlParser.js:138:36) at recursivelyBuildAst (C:\Users\Lee.vscode\extensions\adamvoss.yaml-0.0.8\server\node_modules\vscode-yaml-languageservice\lib\parser\yamlParser.js:124:40) at createJSONDocument (C:\Users\Lee.vscode\extensions\adamvoss.yaml-0.0.8\server\node_modules\vscode-yaml-languageservice\lib\parser\yamlParser.js:211:21) at yamlDocs.map.doc (C:\Users\Lee.vscode\extensions\adamvoss.yaml-0.0.8\server\node_modules\vscode-yaml-languageservice\lib\parser\yamlParser.js:255:53) at Array.map (native) at Object.parse (C:\Users\Lee.vscode\extensions\adamvoss.yaml-0.0.8\server\node_modules\vscode-yaml-languageservice\lib\parser\yamlParser.js:255:42) at Object.parseYAMLDocument (C:\Users\Lee.vscode\extensions\adamvoss.yaml-0.0.8\server\node_modules\vscode-yaml-languageservice\lib\yamlLanguageService.js:65:59) at C:\Users\Lee.vscode\extensions\adamvoss.yaml-0.0.8\server\out\yamlServerMain.js:232:117 at Object.get (C:\Users\Lee.vscode\extensions\adamvoss.yaml-0.0.8\server\out\languageModelCache.js:34:33) at getJSONDocument (C:\Users\Lee.vscode\extensions\adamvoss.yaml-0.0.8\server\out\yamlServerMain.js:240:26)

adamvoss commented 7 years ago

Thanks @lee-baker, that is very helpful!

Unsupported feature, node kind: 5

Node kind 5 means an include reference which are documented in the README as not supported. It would be better if they didn't crash the whole server though. That said, it might not be a whole lot more work to just add support for support rather than adding better failure behavior.

ferdydek commented 7 years ago

Oddly the same happens with YAML Support by Red Hat

TheMasquerader commented 6 years ago

I have the same problem. My setup specs:

The error in the Output is:

C:\Users\Atodic\.vscode\extensions\adamvoss.yaml-0.0.10\server\node_modules\vscode-json-languageservice\lib\services\jsonValidation.js:47
            jsonDocument.syntaxErrors.forEach(addProblem);
                                     ^

TypeError: Cannot read property 'forEach' of undefined
    at JSONValidation.doValidation (C:\Users\Atodic\.vscode\extensions\adamvoss.yaml-0.0.10\server\node_modules\vscode-json-languageservice\lib\services\jsonValidation.js:47:38)
    at yamlDocument.documents.map.d (C:\Users\Atodic\.vscode\extensions\adamvoss.yaml-0.0.10\server\node_modules\vscode-yaml-languageservice\lib\yamlLanguageService.js:48:71)
    at Array.map (native)
    at Object.doValidation (C:\Users\Atodic\.vscode\extensions\adamvoss.yaml-0.0.10\server\node_modules\vscode-yaml-languageservice\lib\yamlLanguageService.js:48:62)
    at validateTextDocument (C:\Users\Atodic\.vscode\extensions\adamvoss.yaml-0.0.10\server\out\yamlServerMain.js:215:21)
    at Timeout._onTimeout (C:\Users\Atodic\.vscode\extensions\adamvoss.yaml-0.0.10\server\out\yamlServerMain.js:205:9)
    at ontimeout (timers.js:386:14)
    at tryOnTimeout (timers.js:250:5)
    at Timer.listOnTimeout (timers.js:214:5)
[Error - 9:06:05 AM] Connection to server got closed. Server will not be restarted.

Thank you!

emman27 commented 6 years ago

Getting the exact same error as @TheMasquerader

xujihui1985 commented 6 years ago

this issue has been opened over year, and this problem still not fixed

will-l-h commented 6 years ago

Use the yaml extension by redhat. It's maintained and this issue had been fixed on it.

https://marketplace.visualstudio.com/items?itemName=redhat.vscode-yaml