YAML syntax errors crash vscode

adamvoss / vscode-yaml

YAML language support, including JSON Schema validation, for Visual Studio Code

https://marketplace.visualstudio.com/items?itemName=adamvoss.yaml

MIT License

29 stars 5 forks source link

YAML syntax errors crash vscode #14

Open timm088 opened 7 years ago

timm088 commented 7 years ago

Running latest vscode and your plugin

When i make some syntax mistakes in yaml files, and vscode correctly tries to highlight those the whole vscode will eventually crash

The error is highlighted, along with every line in the file (seems wrong?)
Not sure where to look for logs, but eventually the window crashes

adamvoss commented 7 years ago

Crashing VSCode is actually kind of impressive :sunglasses: the bulk of the code lives out-of-process in a Language Server that can crash independently. If you find a way to reproduce this please let me know.

Regarding the underline issue, I will look into it when I find the time, but last I looked this behavior comes from the underlying parser, yaml-ast-parser, which is basically saying the document is invalid from there on, but I'll double check.

timm088 commented 7 years ago

I can reproduce everytime...

Alter / malform the yaml and wait for the highlight
scroll down through the file (you need a yaml file long enough for this) and away from your malformed change
watch vscode chugg and eventually crash...

I'm on macOS (latest) and the latest VSCode if that helps?

adamvoss commented 7 years ago

How big are we talking? I tried it with 5,000 lines and was able to scroll to the bottom.

Trying with 10,000 lines it appears to just give up on the underlining, I see the process using the CPU for a while then it drops to zero but the red underline is never drawn (more investigation would be needed to know if that is because of this extension or because of VSCode.

In no test did I reproduce a crash.