search

adaneslavo / More-Unique-Components-for-VP

Adds 3rd and 4th unique component to each civilization.
1 stars 6 forks source link

Tersane lua unnecessary #63

Closed pineappledan closed 6 years ago

pineappledan commented 6 years ago

Tersane has a lua to give Prize Ships promotion to melee naval units trained in city. This can be done with 'TrainedFreePromotion' in sql. I have added to sql now, just want to verify that lua can be deleted.

Prize ship promotion can only be applied to UNITCOMBAT_NAVALMELEE, so there is no issue with applying directly to building.

is there any reason to keep the lua or can it be safely deleted?

Infixo commented 6 years ago

You can just test it to confirm.

adaneslavo commented 6 years ago

I checked table UniPromotion_UnitCombats and Prize Ships is not mentioned there. So it will be given to any unit produced in city with tersane even if it is broken on them. Lua is needed and you need to revert changes made o sql I think.

Infixo commented 6 years ago

No, no. You need to check if putting a combat into the table will prevent this promo for being granted to other combats than the ones mentioned in the table. If yes then lua is not needed, if no then it is needed.

adaneslavo commented 6 years ago

But first we need to check if putting this combat into table is not interering with current VP protmotion usage. I wanted to avoid changing that table.

pineappledan commented 6 years ago

Shouldn’t be a problem. The only other unit that has prize ships is the sea beggar, also navalmelee.

I’ll test it tonight though

pineappledan commented 6 years ago

I tested this, and I was not able to get prize ships to be placed on naval melee units with SQL.

I reverted my changes