adapt-youtube: example.json prevents page from loading

adaptlearning / adapt-youtube

A YouTube Player component for Adapt

GNU General Public License v3.0

6 stars 2 forks source link

adapt-youtube: example.json prevents page from loading #18

Closed chucklorenz closed 3 years ago

chucklorenz commented 3 years ago

FW v5.17.1 YouTube v2.1.0

I copied the example.json into place in components.json and only updated the ids. I get no compile error when building. But the page doesn't load. No errors reported in the dev tools console.

To be clear, this is the page that is not loading; it's not an issue of the video not loading.

Since the README provides little practical information, I tried replacing _media._source with a different video's url--following the same model. Again, the page did not load.

oliverfoster commented 3 years ago

Can you try / review this pr please? @chucklorenz

https://github.com/adaptlearning/adapt-youtube/pull/17

chucklorenz commented 3 years ago

@oliverfoster Tried, but still won't load. Also attempted From my console: And from the cross-site cookie error:

Happy to test/try other suggestions, just let me know...

oliverfoster commented 3 years ago

The cookie bits are just warnings, they can be ignored.

References: https://stackoverflow.com/questions/62984682/cannot-embed-youtube-video-cookie-error-samesite-attribute https://cookie-script.com/blog/how-to-add-youtube-videos-without-cookies https://axbom.com/embed-youtube-videos-without-cookies/

Works for me: youtube1

Example build: 18-youtube-example.zip

chucklorenz commented 3 years ago

Ok, I’ll go through the course today to see what’s causing interference/conflict.

On Oct 19, 2021, at 4:52 AM, Oliver Foster @.***> wrote:

The cookie bits are just warnings, they can be ignored.

References: https://stackoverflow.com/questions/62984682/cannot-embed-youtube-video-cookie-error-samesite-attribute https://cookie-script.com/blog/how-to-add-youtube-videos-without-cookies https://axbom.com/embed-youtube-videos-without-cookies/

Works for me:

Example build: 18-youtube-example.zip

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

chucklorenz commented 3 years ago

I believe googleAnalytics was involved.

I noticed a warning in YouTubeView.js. I logged out of YouTube, but the page still failed to load.
I remembered I had googleAnalytics installed. I added it to the build excludes, and the page loaded with the YouTube component working.
I returned to config.json to see if toggling "_isEnabled" on googleAnalytics would have a consistent impact. It does not; adapt-youTube (and the page) continues to load as expected. Both youTube and googleAnalytics appear to be function correctly now. So I'm guessing that having googleAnalytics installed first somehow interfered with the proper loading/compile order. But admittedly, I'm out of my depth.

Thanks, @oliverfoster

oliverfoster commented 3 years ago

Very odd. Sounds like a caching problem... :/