Change type of TDigest.Group.id from int to long

addthis / stream-lib

Stream summarizer and cardinality estimator.

Apache License 2.0

2.26k stars 556 forks source link

Change type of TDigest.Group.id from int to long #162

Open sgrj opened 5 years ago

sgrj commented 5 years ago

The assumption is that the id is unique. If the id value overflows, it can lead to NullPointerExceptions. Changing the type to long doesn't make overflows impossible, but highly unlikely.

This fixes issues like #100

sgrj commented 5 years ago

Thanks, switching to MergingDigest indeed shows some nice performance improvements.