search

addyosmani / essential-js-design-patterns

Repo for my 'Learning JavaScript Design Patterns' book
http://addyosmani.com/resources/essentialjsdesignpatterns/book/
4.83k stars 792 forks source link

Place logically-grouped <li>s into a single <ul>. #151

Closed prather-mcs closed 9 years ago

prather-mcs commented 9 years ago

Hello. I've never made a pull request before, but hopefully I'm doing things right.

I was reading this section: http://addyosmani.com/resources/essentialjsdesignpatterns/#whatisapattern

And I noticed this problem: http://i.imgur.com/pf7mXGT.png

And I believe my fix is what you want instead.

addyosmani commented 9 years ago

Change LGTM. Thanks!