adgsm / multi-level-push-menu

MultiLevelPushMenu jQuery Plugin implementation
http://multi-level-push-menu.dzunic.net
804 stars 213 forks source link

Better Support Large Site and Menu Contents #179

Closed deltoss closed 7 years ago

deltoss commented 7 years ago

Made Changes to CSS, utilizing fixed positioning so the menu better supports large site content which requires vertical scrolling, and when theres enough items in the menu to require scrolling. This is from looking at the way pushy.js works.

Summary:

Detailed Notes:

adgsm commented 7 years ago

Hi, Thanks for your pull request! I had few minutes to test it and it looks like your changes would break swipe functionality for RTL menus (at least these from demo folder, tested with Chrome on Mac)... BTW there are few examples (here) of how to implement scrolling without showing default browser scrollbars which may look a bit clumsy... Best,

deltoss commented 7 years ago

I checked, and it's indeed broken. I'll take another crack at it to fix the RTL touch support and double check if anything else may of had been broken.

Didn't know you can make your own scrollbars like that. It looks much nicer. I'll check it out in more detail and will implement it in this fork (or maybe another different fork and pull request). Thanks for pointing me to the right direction.