ading2210 / shimboot

Boot a desktop Linux distribution from a Chrome OS RMA shim.
https://shimboot.ading.dev
GNU General Public License v3.0
68 stars 22 forks source link

build_complete.sh: IndexError: list index out of range (nissa) #24

Closed NotDarkn closed 1 month ago

NotDarkn commented 1 month ago

Describe the bug When building for nissa using the build_complete.sh script, the following error appears for both in a virtual machine and a GitHub workflow:

File "<string>", line 9, in <module>
IndexError: list index out of range

To Reproduce Steps to reproduce the behavior:

  1. Clone the repository, or fork the repository.
  2. Run sudo ./build_complete.sh nissa
    • Or if by a GitHub workflow, make a commit or run it manually
      • (change the workflow first to allow it to run manually)
  3. Wait a few seconds and it'll report the same issue I listed.

Expected behavior To proceed like usual just like any other board, such as octopus or dedede.

Screenshots / Photos image image

Target Chrome OS Device (please complete the following information):

Build Device (please complete the following information):

Additional Information: Building a nissa shimboot image manually does work as intended, so if I had to guess: Due to the recent changes that chrome100 has made, nissa may be broken in the recovery image list in some way or another? This is speculation and I could be completely wrong.

ading2210 commented 1 month ago

What does passing DEBUG=1 to the build script give you? (sudo DEBUG=1 ./build_complete.sh)

NotDarkn commented 1 month ago

What does passing DEBUG=1 to the build script give you? (sudo DEBUG=1 ./build_complete.sh)

https://github.com/ading2210/shimboot/assets/73033672/aff17d60-8f58-4b33-ac9b-77a35fcb379f

ading2210 commented 1 month ago

It looks like on some nissa devices the Chromium serving builds API isn't returning any recovery images. image

ading2210 commented 1 month ago

This is fixed in the latest commit.