adivijaykumar / bilby

MIT License
0 stars 2 forks source link

make b1 completely real #20

Closed Kruthi24 closed 3 years ago

Kruthi24 commented 3 years ago

I noticed that b1 wasn't real. It had some imaginary part that was of the order 1e-19 or so. The change I have made now shouldn't even make a difference, but it is somehow. Not sure how important this correction is.

adivijaykumar commented 3 years ago

Do we really need this change?

Kruthi24 commented 3 years ago

As of now, nope. Let's just keep this branch and see.

Kruthi24 commented 3 years ago

Actually, no. Let's just delete it. Dividing is more dangerous than having a small imaginary part.

adivijaykumar commented 3 years ago

OK, closing it then.