adldap / adLDAP

adLDAP is a PHP class that provides LDAP authentication and integration with Active Directory.
GNU Lesser General Public License v2.1
424 stars 204 forks source link

Add To Packagist #4

Open laurinkeithdavis opened 11 years ago

laurinkeithdavis commented 11 years ago

For those of us that use composer, this would be very helpful. Right now, I have to push this into a local repo and then create my own local composer repo to pull it from, so that we can maintain our standard of all 3rd party dependencies are installed by Composer.

samwilson commented 10 years ago

+1 (although I take it you no longer have to have your own fork of this now that there's a composer.json file here?). :-)

Also, as the adlap/adldap package name is taken (by the slightly-diverging fork?), I guess this may be changed to be called rich2k/adldap in Packagist?

Rich2k commented 10 years ago

I have an issue with this as really an incompatible fork shouldn't be using the name adldap anyway when redistributed as it encourages confusion , especially using adldap/adldap

That's a bad decision

samwilson commented 10 years ago

I haven't really looked into what changes have been made in that fork (although I've just switched back to this one from it, and apart from the namespace change nothing has been different so far), but I agree that the name should belong to this original project. You could register adldap as a Github organisation?

Rich2k commented 10 years ago

I've moved it to github.com/adldap/adLDAP

ztec commented 10 years ago

In order to add the lib on packagist, a tag must be set. For now, the only one set in repo does not point to a vertions of the code with a composer.json. (packagist ignore the tag in this situation)

Can you add a tag (v4.0.5) ? I will redirect the package adldap/adldap (on packagist) on this repository once it's done.

datOneperson commented 10 years ago

+1 Yeah can you make a tagged commit with composer.json? Please

Rich2k commented 10 years ago

There already is a release tag

datOneperson commented 10 years ago

The current tagged release doesn't have a composer.json in it, so Composer can't see the tag.

https://github.com/adldap/adLDAP/tree/v4.0.4

nesl247 commented 10 years ago

Any update on this? I really need the search() function. Not being able to easily use this (proper version) of adLDAP via composer is going to be quite annoying.

datOneperson commented 10 years ago

I got it to work by using dev-master and adding the git url to repositories

"repositories": [
    {
        "type": "git",
        "url": "https://github.com/adldap/adLDAP.git"
    },
],
"require": {
    "adldap/adldap": "dev-master",
},
samwilson commented 10 years ago

Any news on the tagging of a new release, @Rich2k (or anyone)?

samwilson commented 9 years ago

No news?

stevebauman commented 9 years ago

Yea this seriously needs to be addressed. This isn't a difficult fix. Any possibility of adding more maintainers so someone with dev time can continue working with this repo?

The large majority of frameworks rely on composer for package management, and the one on packagist right now is severely outdated and has some large bugs from long ago.

stevebauman commented 9 years ago

Added my own fork to packagist. This will consistently be updated with this main repository. I've renamed the repo to adldap-fork for a clear indication for users that it is a fork and not the main repo.

Anyone interested in using the updated fork in composer:

"stevebauman/adldap-fork": "4.0.*"

Packagist link

samwilson commented 9 years ago

@stevebauman is right, this isn't a difficult thing to fix. @Rich2k are you still around? If not, would you be willing to make someone else a maintainer?

In the interim, I reckon @stevebauman is right; I'm going to use his fork for the time being. :)