Not clear what the determining properties are for a template

adlnet / xapi-profiles

A set of documents addressing the structure of and supporting services for xAPI Profiles.

https://adlnet.gov/projects/xapi/

Apache License 2.0

54 stars 27 forks source link

Not clear what the determining properties are for a template #167

Closed garemoko closed 7 years ago

garemoko commented 7 years ago

Based on calls, I know that the following are determining properties for a template. This needs to be clearer in the spec.

verb
objectActivityType
contextGroupingActivityType
contextParentActivityType
contextOtherActivityType
contextCategoryActivityType
attachmentUsageType

fugu13 commented 7 years ago

This is defined in text:

The verb, object activity type, attachment usage types, and context activity types listed are the determining properties.

We can list them more explicitly and/or rearrange if you think that would help clarity, of course.

garemoko commented 7 years ago

I must have missed that text on reading it. So we can either blame me as the read and do nothing, or assume that because I missed it, it needs to be clearer. I'm happy either way.

fugu13 commented 7 years ago

It's been made more distinctly present in a recent PR if you want to take a look