search

admc / wd

A node.js client for webdriver/selenium 2.
Other
1.53k stars 404 forks source link

Update keep-alive logic #609

Closed vrunoa closed 4 years ago

vrunoa commented 4 years ago

Currently, the connection is not keep-alive over a test life, during some investigation at Sauce I notice this Appium(webdriver) client is closing TCP connections before any new command. Here's some Wireshark TCP dump showing it:

before

👆🏻Before any new command(request) there's a [FIN,ACK]

With these changes looking at TCP dumps we can see the socket is kept open, so there's no more resync before new requests 👇🏻

Screen Shot 2019-12-29 at 9 39 30 PM

Let me know what you guys think

imurchie commented 4 years ago

@vrunoa Can you rebase with master and then re-push here? I've fixed the Sauce Connect usage so the tests ought to actually run for the PR. Thanks!

imurchie commented 4 years ago

Something went awry there.

vrunoa commented 4 years ago

I made a mess on rebase, I'll open a new PR 🤦🏻‍♂️