search

admc / wd

A node.js client for webdriver/selenium 2.
Other
1.53k stars 404 forks source link

add httpAgent as right now the connection is not kept alive #612

Closed vrunoa closed 4 years ago

vrunoa commented 4 years ago

Currently, the connection is not keep-alive over a test life, during some investigation at Sauce I notice this Appium(webdriver) client is closing TCP connections before any new command. Here's some Wireshark TCP dump showing it:

before-keep-alive

👆🏻Before any new command(request) there's a [FIN, ACK]

With these changes looking at TCP dumps we can see the socket is kept open, so there's no more resync before new requests 👇🏻

after-keep-alive
vrunoa commented 4 years ago

@imurchie here we go again 😃

imurchie commented 4 years ago

I don't have the ability to publish this, but I've pinged @jlipps on Slack about it.

vrunoa commented 4 years ago

@imurchie @jlipps if I create a patch for an old version of wd, once we use internally to sauce, could be considered for publishing?

imurchie commented 4 years ago

@vrunoa Any idea about how to mitigate the problem this is causing in the Appium build?

For instance, https://travis-ci.org/appium/appium/jobs/634369625