search

adobe-fonts / source-sans

Sans serif font family for user interface environments
https://adobe-fonts.github.io/source-sans
SIL Open Font License 1.1
3.49k stars 229 forks source link

Add missing anchors #131

Closed khaledhosny closed 6 years ago

khaledhosny commented 6 years ago

No idea if these anchors are used at all, but the some masters have them and the others don’t, which breaks building a variable font with fontmake (at least for me). Alternatively the anchors can be dropped from the masters that have them if they aren’t actually needed.

miguelsousa commented 6 years ago

There are a few open issues related to anchors but I'm surprised that you ran into this while building the fonts with fontmake. The current variable TTFs were built with a slightly modified version of fontmake. See commands in the shell script.

Is your version building the mark/mkmk features on-the-fly from the data in the UFOs, instead of using the existing features (e.g. Regular mark)? That could explain the difference, I'm guessing.

khaledhosny commented 6 years ago

Is your version building the mark/mkmk features on-the-fly from the data in the UFOs, instead of using the existing features (e.g. Regular mark)?

Yes. I’m not actually building Source Sans Pro directly, but I merge it with my Arabic font (Mada) and it is a bit easier merge the existing data from UFO glyph than to merge generated feature files.

khaledhosny commented 6 years ago

If the anchor support in Source Sans Pro is not meant for production (or you think is not mature enough), I can for now strip out all the anchors when merging the fonts.

miguelsousa commented 6 years ago

I think most of the current anchor support is solid; there's just a few inconsistencies that need to be worked out. I'm going to go ahead and merge your changes. Thanks!