[ ] I have added test code and data to prove that my code functions correctly
[x] I have verified that new and existing tests pass locally with my changes
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
I think I finally have all local tests working except for test_infinite_loop_with_dflt_lookups_bug965(). That test fails before and after my changes, so I don't think it'd be related.
Unlike the previous bugs I've encountered , this strikes me as one that could probably use a test? The thing is, as I've mentioned elsewhere, I'm not sure if it's possible to trigger this bug using existing tools, and I'm still in the process of learning Python enough to write a test. If you think it warrants a test and could create one, that would certainly help in my learning process.
Description
This is a patch to fix bug #1647. Basically, I moved the static
dsigCountvariable outside therefillDSIG()function, and reset it inhotReuse().Checklist:
I think I finally have all local tests working except for
test_infinite_loop_with_dflt_lookups_bug965(). That test fails before and after my changes, so I don't think it'd be related.Unlike the previous bugs I've encountered , this strikes me as one that could probably use a test? The thing is, as I've mentioned elsewhere, I'm not sure if it's possible to trigger this bug using existing tools, and I'm still in the process of learning Python enough to write a test. If you think it warrants a test and could create one, that would certainly help in my learning process.