search

adobe-type-tools / afdko

Adobe Font Development Kit for OpenType
https://adobe-type-tools.github.io/afdko/
Other
1.06k stars 167 forks source link

[tx] fix segfaults due to old function call #1649

Closed kaydeearts closed 1 year ago

kaydeearts commented 1 year ago

Description

Frank reported a bug where makeotf crashed with segfault due to an unexpected point type in a glif file. There was error handling already set up for this, but called a function getBufferContextPtr that was meant for the pre-libxml2 way of parsing tokens. I removed all calls of this function where the caller is using the libxml2 way of parsing and added some test cases.

Side note: There are some unused token parsing functions leftover in uforead that I would like to clean up in a separate PR. I partly kept them there in case they illustrated functions that we needed to convert to libxml2 — doesn't look like it from a quick glance, but I'll investigate this further.

Checklist:

kaydeearts commented 1 year ago

I think we've discussed this before already, but we definitely need to make these fatals vs fprintf vs returning error code ways of error handling more consistent. Let me know if you have thoughts for the ones I did in this PR, and we can also discuss the overall usage of these various ways in our next team meeting!

skef commented 1 year ago

I think we've discussed this before already, but we definitely need to make these fatals vs fprintf vs returning error code ways of error handling more consistent. Let me know if you have thoughts for the ones I did in this PR, and we can also discuss the overall usage of these various ways in our next team meeting!

Logging is already quite different in my future-work branches. The less we change things in develop the less work I have to do porting PRs over.

kaydeearts commented 1 year ago

LGTM

That was SO FAST that I couldn't even finish writing a response to Frank's message 😆 thank you!