adobe-type-tools / afdko

Adobe Font Development Kit for OpenType
https://adobe-type-tools.github.io/afdko/
Other
1.06k stars 167 forks source link

Remove `types` setting from `pull_request` #1664

Open miguelsousa opened 1 year ago

miguelsousa commented 1 year ago

Removes the types setting from pull_request section of workflow files.

This setting was originally added to prevent the CI from triggering twice (on push and on pull-request) with each commit to a branch with an opened PR. The current workflow configuration works fine for developers that have privileges to push branches to the repo, but it has the adverse side-effect of getting the CI stuck on PRs from forks, if the external developer makes commits to their branches after the PR has been opened.

I've made this same change on another project and I'm only seeing duplicate CI runs on one kind of event: when the PR is opened. After that, all commits to the branch only trigger pull_request CI runs (and not push CI runs).

miguelsousa commented 1 year ago

Adding concurrency didn't make a difference. The CI runs are still triggering on both push and pull_request events. 😖

dups