CIF-1213: Improve Venia test coverage to meet CM goals - Githubissues

adobe / aem-cif-project-archetype

Maven template to create new CIF Project AEM projects that follow best practices

Apache License 2.0

20 stars 12 forks source link

CIF-1213: Improve Venia test coverage to meet CM goals #106

Closed hbacila closed 4 years ago

hbacila commented 4 years ago

Description

add unit test for MyProductTeaserImpl
skip delegation for deprecated methods (CM code quality recommendation)

CM code scanning identified low code coverage (53%). Therefore new unit test was added for MyProductTeaserImpl model. Code coverage increased to 87.9%

Related Issue

https://jira.corp.adobe.com/browse/CIF-1213

Motivation and Context

Code coverage should be over 80% (although the CM threshold is 50%)

How Has This Been Tested?

the fix was applied the reference app at https://git.cloudmanager.adobe.com/stage-commerceinternalstage/CommerceInternalStageProgram-p10603/ (branch horea)
new Non-Production pipeline created for Code Quality only using the branch horea
pipeline execution https://experience-stage.adobe.com/#/@commerceinternalstage/cloud-manager/pipelineexecution.html/program/10603/pipeline/37602/execution/17754 shows increased code coverage

Screenshots (if appropriate):

Types of changes

[x ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ x] I have signed the Adobe Open Source CLA.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ x] I have read the CONTRIBUTING document.
[ x] I have added tests to cover my changes and the overall coverage did not decrease.
[ ] All unit tests pass on CircleCi.
[ x] I ran all tests locally and they pass.