CIF-1438 - Reloading a PLP results in "No resource found" error - Githubissues

adobe / aem-cif-project-archetype

Maven template to create new CIF Project AEM projects that follow best practices

Apache License 2.0

20 stars 12 forks source link

CIF-1438 - Reloading a PLP results in "No resource found" error #112

Closed cjelger closed 4 years ago

cjelger commented 4 years ago

remove url_path suffix from category urls on author instance
create a dedicated config for publish instance to keep the suffix so we can still demo the rewrite rules with Sling mappings
update URL template formats to new version

Description

The url_path suffix in category URLs is problematic in the "preview" mode on author instances, because the URL ends up having two suffixes.

How Has This Been Tested?

Manually tested on author and publish instances.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes and the overall coverage did not decrease.
[x] All unit tests pass on CircleCi.
[x] I ran all tests locally and they pass.

mhaack commented 4 years ago

Change looks good to me, did you also create a PR for the AEM Archetype? This here would not be released any more.