Fixing enabled and visible attributes of Button CC - Githubissues

adobe / aem-core-forms-components

Standardized components to build forms with AEM Forms

Apache License 2.0

26 stars 59 forks source link

Fixing enabled and visible attributes of Button CC #1308

Closed muskgupta closed 3 months ago

muskgupta commented 3 months ago

Description

Fixed the enabled and visible attributes to reflect correctly in forms for button core component.

JIRA : https://jira.corp.adobe.com/browse/FORMS-15167

Related Issue

Motivation and Context

Without this change, the button component in forms was not correctly populating true and false values to 'data-cmp-enabled' and 'data-cmp-visible' attributes.

How Has This Been Tested?

Tested the changes using cypress.

Screenshots (if appropriate):

Screenshot 2024-07-08 at 2 00 08 PM

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes and the overall coverage did not decrease.
[ ] All unit tests pass on CircleCi.
[x] I ran all tests locally and they pass.

adobe-bot commented 3 months ago

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	100	75

adobe-bot commented 3 months ago

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	93	96	100	75

adobe-bot commented 3 months ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot commented 3 months ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot commented 3 months ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot commented 3 months ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot commented 3 months ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot commented 3 months ago

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	88	96	96	75

adobe-bot commented 3 months ago

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot commented 3 months ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot commented 3 months ago

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot commented 3 months ago

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	90	96	96	75

adobe-bot commented 3 months ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot commented 3 months ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot commented 3 months ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.73%. Comparing base (231a14a) to head (370d255). Report is 1 commits behind head on dev.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## dev #1308 +/- ## ========================================= Coverage 81.73% 81.73% Complexity 853 853 ========================================= Files 97 97 Lines 2267 2267 Branches 305 305 ========================================= Hits 1853 1853 Misses 255 255 Partials 159 159 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.