adobe / aem-core-wcm-components

Standardized components to build websites with AEM.
https://docs.adobe.com/content/help/en/experience-manager-core-components/using/introduction.html
Apache License 2.0
723 stars 737 forks source link

[SITES-22419] Follow up on SITES-19714 Fix Release #2796

Closed YahorC closed 5 days ago

YahorC commented 1 week ago
Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix?
Minor: New Feature?
Major: Breaking Change?
Tests Added + Pass? Yes
Documentation Provided Yes (code comments and or markdown)
Any Dependency Changes?
License Apache License, Version 2.0

(https://jira.corp.adobe.com/browse/SITES-22419) Jira issue. Adding this check, in order to get false result, when we have current page language code longer then from another list of pages (for example because of previous implementation when we have 2 under root with names zh and zh_cm component wont be able to show link to second one)

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.21%. Comparing base (7582ad6) to head (7a3712b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2796 +/- ## ============================================ + Coverage 87.17% 87.21% +0.03% - Complexity 2683 2687 +4 ============================================ Files 235 235 Lines 7166 7170 +4 Branches 1094 1096 +2 ============================================ + Hits 6247 6253 +6 Misses 363 363 + Partials 556 554 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

LSantha commented 1 week ago

@YahorC , could you please add at least one unit test case for your fix, possibly using somewhat realistic path values like the ones mentioned in the ticket?

sonarcloud[bot] commented 5 days ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud