Closed sanoodles closed 2 years ago
:exclamation: No coverage uploaded for pull request base (
master@bec40fd
). Click here to learn what that means. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #8 +/- ##
=========================================
Coverage ? 98.21%
=========================================
Files ? 33
Lines ? 393
Branches ? 86
=========================================
Hits ? 386
Misses ? 7
Partials ? 0
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update bec40fd...d6f08e3. Read the comment docs.
Missing Adobe CLA
Fixes adobe/aem-react-core-wcm-components-base#6
Removes output of dollar sign before action title on TeaserV1
Description
Cleanup dollar sign and create corresponding unit test
Related Issue
https://github.com/adobe/aem-react-core-wcm-components-base/issues/6
Motivation and Context
Teaser action links output a title that does not correspond to the specification; prepending a dollar sign that, yeah, is a typo.
How Has This Been Tested?
Extended TeaserV1.tests.tsx to check for the HTML from .cmp-teaser__action-container
Ran
npm run test
with the original code and there is a FAIL on TeaserV1.test.tsxThen ran again
npm run test
with the changed code in TeaserV1.tsx and all tests are green.Screenshots (if appropriate):
Types of changes
Checklist: