search

adobe / aem-spa-project-archetype

Maven Archetype for creating new AEM SPA projects
Apache License 2.0
61 stars 32 forks source link

Use consistent naming for page component #95

Closed samuelmeuli closed 4 years ago

samuelmeuli commented 5 years ago
Q                       A
Fixed Issues? Fixes #53
Patch: Bug Fix? No
Minor: New Feature? No
Major: Breaking Change? Yes
Tests Added + Pass? No
Documentation Provided No
Any Dependency Changes? No
License Apache License, Version 2.0

Renames MainContentComponent to PageComponent in the Angular app to get consistent naming with the React app.

habansal commented 5 years ago

I am not an expert in the area but isn't the MainContentComponent being exported like an API ? Are we breaking the API ? Wouldn't this be Backwards In-compatible ?

habansal commented 5 years ago

I re-thought about this and I guess, the archetype is to be used only once while starting the project. So, probably, we won't need to bother about name/API change. Better to confirm with others as well

samuelmeuli commented 5 years ago

I agree that this should be a one-time operation. The archetype:generate command can be used for an existing project, but I assume that would just overwrite the existing (and possibly modified) files? So taking over desired changes manually seems like a better option.

Furthermore, the archetype currently isn't set up to allow this anyway.