search

adobe / aem-spa-project-core

Contains abstraction for core Adobe Experience Manager and Single Page Application interface, the page.
Apache License 2.0
29 stars 29 forks source link

[#9] SSR requests fail for core components 2.11.1 #10

Closed josephrignanese closed 4 years ago

josephrignanese commented 4 years ago

Fix for #9

codecov[bot] commented 4 years ago

Codecov Report

Merging #10 into master will increase coverage by 8.50%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #10      +/-   ##
============================================
+ Coverage     70.98%   79.48%   +8.50%     
- Complexity       71       89      +18     
============================================
  Files             7        7              
  Lines           193      195       +2     
  Branches         30       30              
============================================
+ Hits            137      155      +18     
+ Misses           39       23      -16     
  Partials         17       17
Impacted Files Coverage Δ Complexity Δ
...e/aem/spa/project/core/internal/impl/PageImpl.java 77.77% <100.00%> (+38.24%) 31.00 <2.00> (+18.00)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 86a4bfb...d1383bc. Read the comment docs.

SushantBhasin commented 4 years ago

Can you also add tests for new code

josephrignanese commented 4 years ago

Hi @SushantBhasin, I've added tests to cover this and other methods already delegated to the core components Page.