search

adobe / aem-spa-project-core

Contains abstraction for core Adobe Experience Manager and Single Page Application interface, the page.
Apache License 2.0
29 stars 29 forks source link

aem-spa-project-core + react sap - adobe analytics support #48

Open m-rather-d opened 2 years ago

m-rather-d commented 2 years ago

We are working on a new development using aem-spa-project-core with React frontend and would like to implement Adobe Analytics as described here: https://experienceleague.adobe.com/docs/experience-manager-core-components/using/developing/data-layer/overview.html?lang=en

<dependency>
                <groupId>com.adobe.aem</groupId>
                <artifactId>spa.project.core.ui.apps</artifactId>
                <type>zip</type>
                <version>${spa.project.core.version}</version>
            </dependency>
            <dependency>
                <groupId>com.adobe.aem</groupId>
                <artifactId>spa.project.core.core</artifactId>
                <version>${spa.project.core.version}</version>
            </dependency>

We are also utilzing the SPA React libs:

"@adobe/aem-core-components-react-base": "^1.1.8",
    "@adobe/aem-core-components-react-spa": "^1.2.0",
    "@adobe/aem-react-editable-components": "^1.1.6",
    "@adobe/aem-spa-component-mapping": "^1.1.1",
    "@adobe/aem-spa-page-model-manager": "^1.3.11",

It seems that Adobe Analytics is not supported on SPA Core and SPA react libraries. There is nothing explicitly mentioned in documentation, and we would like some confirmation.

Note: /libs/core/wcm/components/page/v3/page/page.html (HTL core page) This has logic to include 'data-cmp-data-layer-enabled' on body tag, whereas: /apps/spa-project-core/components/page/page.html (SPA core page) does not have it.

Neither do any of the react core components output any of the following data tags on their respective markups:

  data-cmp-data-layer
  id

Looking at the react code for the Title component, There is no reference to anything related to Analytics data: https://github.com/adobe/aem-react-core-wcm-components-base/blob/master/src/authoring/title/v2/TitleV2.tsx

Please advise:

  1. Is Adobe Analytics supported for Core Components + SPA + React combination?
  2. If not, is this something that is going to be supported?

Marking this as 'bug' and not 'feature request', due to the assumption that the page component should work at part between classical and spa versions.