search

adobe / commerce-cif-connector

AEM Commerce connector for Magento and GraphQL
Apache License 2.0
43 stars 27 forks source link

All products not shown in Product Finder when authoring #84

Open geertsmichael opened 4 years ago

geertsmichael commented 4 years ago

Expected Behaviour

When editing a page in Touch UI, the "content finder" should show all products. This is remaining empty: Schermafbeelding 2020-01-22 om 16 44 17

When editing a page in Touch UI, the "content finder" option to "filter path" on Products, only navigates on /etc/commerce and not /var/commerce:

Schermafbeelding 2020-01-22 om 16 45 36

Actual Behaviour

When editing a page in Touch UI, the "content finder" doesn't show all products. if searching for "hoodie" it will show products. But we expect like "assets", to see a set of products. When editing a page in Touch UI, the "content finder" the "Enter path" option should show /var/commerce as well.

Reproduce Scenario (including but not limited to)

Open a page of the Venia site (archetype 0.6.2) & open the "Products" panel. No products are shown.

Platform and Version

AEM 6.4.5 CIF Connector 0.7.1 CIF Core Component 0.6.0

Logs taken while reproducing problem

22.01.2020 15:18:52.107 WARN [0:0:0:0:0:0:0:1 [1579702732107] GET /bin/wcm/contentfinder/cifproduct/view.html HTTP/1.1] com.day.cq.commons.servlets.AbstractPredicateServlet Predicate provider not bound.

mhaack commented 4 years ago

How does this issue is related to #85 ? In #85 looks like you could drag & drop but that requires products are loading in the content finder?

geertsmichael commented 4 years ago

Correct after searching. Just opening the product finder doesn’t show products. After searching it does. Other issue , I can’t limit my search in 1 catalog only. As I cannot select a /var/commerce folder.

mhaack commented 4 years ago

Other issue , I can’t limit my search in 1 catalog only.

That is something we plan for one of the next releases. Config will be more streamlined and pickers will respect the catalog, storeview etc. which are assigned to a side.

geertsmichael commented 4 years ago

Correct after searching. Just opening the product finder doesn’t show products. After searching it does.

After testing again on a clean instance, I am seeing products even without filtering. Could this be related because we also have products in /etc/commerce/products?

mhaack commented 4 years ago

This might be. Above you wrote you run AEM 6.4.5 which actually should not have anything in /etc/commerce/products ??? Should be /var/commerce/products? But nevertheless, I recommend not mixing old/classic products in JCR with CIF.

cjelger commented 4 years ago

@geertsmichael I checked again in the commerce-core-bundle and if there is a /etc/commerce/products folder, all the commerce components related to products path will always open this path. You should really have either /etc/commerce/products or /var/commerce/products but not both. The new location is /var/commerce/products.

Now while your issue is caused by having products in /etc/commerce/products, we also found out that there is still a bug in the asset picker that makes it use /etc/commerce/products. We are currently working on this to understand how this problem appeared.